[Webkit-unassigned] [Bug 112419] [GTK][WK2] MiniBrowser custom URI scheme support

Mon Apr 1 04:06:07 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=112419

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #195949|review?                     |review-
               Flag|                            |

--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-01 04:04:18 PST ---
(From update of attachment 195949)
View in context: https://bugs.webkit.org/attachment.cgi?id=195949&action=review

Looks better, setting r- because of the leaks and style issues.

> Tools/MiniBrowser/gtk/BrowserWindow.c:140
> +    gtk_entry_set_text(GTK_ENTRY(window->uriEntry), getExternalURI(webkit_web_view_get_uri(webView)));

This is leaking the uri, you should either use a variable to free the uri after set_text, or cache the uri in the window structure and make getExternalURI return a const char *

> Tools/MiniBrowser/gtk/BrowserWindow.c:301
> +        titleOrURI = getExternalURI(webkit_web_view_get_uri(window->webView));

titleOrURI is const char, getExternalURI returns a new allocated string that you are leaking here.

> Tools/MiniBrowser/gtk/BrowserWindow.c:665
> +        webkit_web_view_load_uri(window->webView, getInternalURI(uri));

Same leak here.

> Tools/MiniBrowser/gtk/main.c:212
> +        contents = g_strdup_printf("<html><body><h1>WebKitGTK+ MiniBrowser</h1><p>About page example.</p><p>Version: %d.%d.%d</p></body></html>",

We don't need to say this is an about page example, just a use a sentence like any other about app. WebKitGTK+ MiniBrowser 2.0.0 The WebKit2 test browser of the GTK+ port. Or something similar.

>>> Tools/MiniBrowser/gtk/main.c:215
>>> +                                   webkit_get_micro_version ());
>> 
>> Extra space before ( in function call  [whitespace/parens] [4]
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Fix all the style issue please.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.