[Webkit-unassigned] [Bug 96637] Remove V8DOMWindowShell::getEntered

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 28 16:29:18 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96637





--- Comment #31 from Dan Carney <dcarney at google.com>  2012-09-28 16:29:43 PST ---
(From update of attachment 166267)
View in context: https://bugs.webkit.org/attachment.cgi?id=166267&action=review

>> Source/WebCore/bindings/v8/V8Binding.cpp:314
>> +    V8DOMWindowShell::IsolatedContextData* isolatedShellData;
> 
> Would you be willing to initialize this scalar to 0? It always makes me worry to see uninitialized pointers.

done

>> Source/WebCore/bindings/v8/V8DOMWindowShell.h:63
>> +            PassRefPtr<SecurityOrigin> securityOrigin)
> 
> You can merge these lines.

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list