[Webkit-unassigned] [Bug 97186] QuickTime movie is not scaled when opened by movie file URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97186





--- Comment #14 from Eric Carlson <eric.carlson at apple.com>  2012-09-28 10:20:02 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> I supposed that in that case default constructor of Stirng() will init it as empty string. Thus pluginNameForMimeType will not be able to find plugin name for it and just return empty string, so no additional problems will arise. Am I wrong?
> I can re-design code in other way, if you think that present code have problems, but could you tell, which variant of our patches is better - with global definition of "scale" attribute or local one?

"uninitialized" was the wrong word to use because you are correct that it won't cause any harm, but it is inefficient to call a function that you know will fail. IOW, something like this would be more efficient:

    String pluginName = pluginData && !mimeType.isEmpty() ? pluginData->pluginNameForMimeType(mimeType) : String();

I think the patch with the scale as a global attribute makes more sense, as we also define other non-spec'd attributes globally (eg. "classid").

I am concerned that this patch will not be a positive change for most users. While I agree that it will be an improvement when video file that is larger than the browser window I don't think that is the most common case. Because WebKit always tries to create a <video> element first and only creates an <embed> if that fails to load, and because in my experience the kinds of files that end up going to the QuickTime plug-in are typically smaller than the browser window, and these will *not* usually look good scaled up to the size of the window.

What types of files to you encounter that end up in a PluginDocument?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.