[Webkit-unassigned] [Bug 94925] [EFL][UT]Refactoring an implementation of testing framework for wk1.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94925





--- Comment #46 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-09-28 03:33:05 PST ---
(From update of attachment 166185)
View in context: https://bugs.webkit.org/attachment.cgi?id=166185&action=review

Please verify this patch won't influence on both release and debug build.

> Source/WebKit/PlatformEfl.cmake:324
> +    ${WEBKIT_DIR}/efl/tests/UnitTestUtils/EWKTestEnvironment.cpp

Wrong alphabetical order.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestEnvironment.h:27
> +    EWKTestEnvironment(bool useX11Window);

Missing explicit keyword

> Source/WebKit/efl/tests/test_ewk_view.cpp:36
> +    ewk_view_editable_set(webView(), EINA_FALSE);

Please use true instead of EINA_FALSE

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.