[Webkit-unassigned] [Bug 91187] [EFL] Add dummy implementation of File system API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91187





--- Comment #10 from Dongwoo Joshua Im (dwim) <dw.im at samsung.com>  2012-09-28 00:47:11 PST ---
(In reply to comment #9)
> (From update of attachment 166141 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166141&action=review
> 
> >>> Source/WebCore/PlatformEfl.cmake:332
> >>> +IF (ENABLE_FILE_SYSTEM)
> >> 
> >> This condition here is not really needed since the file is already protected by #if ENABLE(FILE_SYSTEM)
> > 
> > Referring CMakeLists.txt and PlatformEfl.cmake,
> > many files are only included when the flag is enabled, even though the files protect using the macro in itself.
> > I think that's because it could reduce the compilation time.
> > 
> > So, I prefer to keep this in my patch.
> > 
> > What do you think?
> 
> I prefer not to guard this in cmake file again. I don't wanna disturb cmake file using excessive ENABLE_ macro. According to my previous build time measurement, there is no build time increase.
> 

Ok, I will follow your recommendation.

> > Source/WebCore/platform/efl/AsyncFileSystemEfl.cpp:2
> > + * Copyright (C) 2012 Samsung Electronics
> 
> Is there any reason to use LGPL ?
> 

No specific reason. ;)
I just didn't recognized the currently created files on EFL port are in the BSD license.
I will change this.

> >>> Source/WebCore/platform/efl/AsyncFileSystemEfl.cpp:42
> >>> +void AsyncFileSystem::openFileSystem(const String& basePath, const String& storageIdentifier, bool, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
> >> 
> >> Isn't it generating a lot of warnings all these unused arguments?
> > 
> > I've ignored these warnings because these will be disappeared by the following patches, and those warnings wouldn't be shown in usual case because FILE_SYSTEM is disabled currently.
> > 
> > But, for the quality of "this" patch, I will fix this.
> 
> I think it would be good if you add variable name when you will use it.

yes, I will.

> 
> > Source/WebCore/platform/efl/AsyncFileSystemEfl.h:18
> > + *
> 
> Looks unneeded line.

This line is removed due to the license change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.