[Webkit-unassigned] [Bug 91187] [EFL] Add dummy implementation of File system API.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 27 22:43:15 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91187





--- Comment #7 from Christophe Dumez <christophe.dumez at intel.com>  2012-09-27 22:43:39 PST ---
(From update of attachment 166141)
View in context: https://bugs.webkit.org/attachment.cgi?id=166141&action=review

> Source/WebCore/ChangeLog:9
> +        Implementaion patches will be created followed by this.

"implementation"
"followed by this" -> "later" or "after this".

> Source/WebCore/PlatformEfl.cmake:332
> +IF (ENABLE_FILE_SYSTEM)

This condition here is not really needed since the file is already protected by #if ENABLE(FILE_SYSTEM)

> Source/WebCore/platform/efl/AsyncFileSystemEfl.cpp:42
> +void AsyncFileSystem::openFileSystem(const String& basePath, const String& storageIdentifier, bool, PassOwnPtr<AsyncFileSystemCallbacks> callbacks)

Isn't it generating a lot of warnings all these unused arguments?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list