[Webkit-unassigned] [Bug 94508] RenderLayer::paintLayerContents replace paint phase bit mask with enumeration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94508


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




--- Comment #4 from Dirk Schulze <krit at webkit.org>  2012-09-27 20:26:26 PST ---
(In reply to comment #3)
> I don't understand what your proposal is. Could it be possible for you to clarify what you are trying to achieve?
> 
> > Why do they need to be a bit mask? When do we set more than one bit at once?
> 
> The different operations in PaintLayerFlags are not orthogonal at all, which would be required to use an enumeration: you can be painting with some combination of them. Look at RenderLayer::paintOverlayScrollbars for an example. Alternatively painting some transparent transformed object with a reflection would trigger different sets of flags to be set at different point during the painting.

Yes, we discussed it in IRC before, just forgot to close the bug. I was not ware that e.g reflection can be set with other things as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.