[Webkit-unassigned] [Bug 17427] Line breaking opportunities at the end of a text node are missed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17427





--- Comment #27 from Michael Saboff <msaboff at apple.com>  2012-09-27 11:48:23 PST ---
(In reply to comment #26)
> I agree that optimizations for ICU platforms would be nice. A few other considerations also come to mind. First, fixing rendering bugs (which are causing problems in real-world applications, see comments #6 and #11) is generally more important than platform-specific optimizations. Second, I am a volunteer: I have limited time, and I only have access to Linux machines. I could probably come up with a UText solution but I would need help. Third, the line-breaking functions in TextBreakIterator.h currently expect a UChar*, not a UText:
> 
> TextBreakIterator* acquireLineBreakIterator(const UChar*, int length, const AtomicString& locale);
> void LazyLineBreakIterator::reset(const UChar* string, int length, const AtomicString& locale);
> 
> How would you suggest changing these functions so that they accept a UText when available and a String or UChar* when not? Won't any change here affect all platforms? If it affects all platforms, how can I test my changes?
> 
> Thanks for the help.

I think the best way to do this is to create a new acquireLineBreakIterator() and LazyLineBreakIterator::reset() that take the list of RenderText's or TextNode's that contain all of the strings.  The implementation of those new methods could be in a ICU file.  It may be sufficient to provide this implementation and leave other implementations to other platforms.  You might need to #if the definitions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.