[Webkit-unassigned] [Bug 96023] Expose ability to create WebUserMediaRequest from chromium side

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96023





--- Comment #28 from Justin Lin <justinlin at chromium.org>  2012-09-27 10:48:41 PST ---
(In reply to comment #25)
> (From update of attachment 165967 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165967&action=review
> 
> This still strikes me as the wrong approach.  It's tough to write correct custom bindings in the first place.  It's even tougher to write them in the wrong layer (i.e., the WebKit layer rather than the bindings themselves).
> 
> > Source/WebKit/chromium/ChangeLog:6
> > +        Reviewed by Adam Barth.
> 
> This is not accurate.  I have not reviewed this patch.  Please leave the NOBODY (OOPS!) line in the ChangeLog.  The tools will fill it out with the proper reviewer when landing your patch.

Ah, didn't realize the scripts did that.

> 
> > Source/WebKit/chromium/src/WebDeviceMediaRequest.cpp:54
> > +    WebFrame* webFrame = WebFrame::frameForCurrentContext();
> 
> It's very unlikely that we should call frameForCurrentContext.
> 
> > Source/WebKit/chromium/src/WebDeviceMediaRequest.cpp:61
> > +    ScriptExecutionContext* scriptExecutionContext = frame->document()->scriptExecutionContext();
> 
> This is really the wrong way to get the current script execution context.  The bindings know how to do this work properly.  Doing this work from the WebKit layer is pretty awkward.

(In reply to comment #26)
> I still don't really understand the problem you're trying to solve, which makes it difficult to suggest a better design.  Maybe we should talk over VC?

That sounds good! I'll schedule something.

(In reply to comment #27)
> One option is to expose a JavaScript API only to extensions.  We typically don't do that since WebKit is mainly focused on providing APIs that are part of the open web platform.  If I had a better understanding of the underlying problem you're trying to solve, I might have more useful suggestions.
> 

Something like that might work.

> I really think the approach of trying to write custom bindings code in the WebKit layer is unworkable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.