[Webkit-unassigned] [Bug 96477] [WK2][GTK] Add API to get the favicon for a WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96477





--- Comment #5 from Mario Sanchez Prada <msanchez at igalia.com>  2012-09-27 06:52:21 PST ---
(In reply to comment #4)
> (From update of attachment 165591 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165591&action=review
> 
> Patch looks great, the unit tests part will probably need to be updated to the changes in bug #96476.
> 
> > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:241
> > +    iconFromWebView = webkit_web_view_get_favicon(test->m_webView.get());
> > +    g_assert(iconFromWebView);
> > +    cairo_surface_destroy(iconFromWebView);
> 
> I could check the icon contents, or simply that cairo_image_surface_get_width/height are > 0
> 
> > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:272
> > +    FaviconDatabaseTest::add("WebKitFaviconDatabase", "get-favicon-from-webview", testGetFaviconFromWebView);
> 
> This could be FaviconDatabaseTest::add("WebKitWebView", "favicon", testWebViewFavicon); since wew are testing web view api even if it's run in the favicon database test. We do that in other tests.

Thanks for the review. I'll address those issues when landing, as soon as bug 96476 is fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.