[Webkit-unassigned] [Bug 90017] [Meta] [Shadow] contenteditable attribute for distributed nodes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90017





--- Comment #8 from Takashi Sakamoto <tasak at google.com>  2012-09-27 02:21:14 PST ---
(From update of attachment 161609)
View in context: https://bugs.webkit.org/attachment.cgi?id=161609&action=review

>>>> Source/WebCore/css/StyleResolver.cpp:1783
>>>> +    if (m_distributedToInsertionPoint) {
>>> 
>>> This seems like an odd place for this code. Should this not be in StyleResolver::applyProperty?
>> 
>> In StyleResolver::applyProperty, I found that "case CSSPropertyWebkitUserModify:" is "ASSERT_NOT_REACHED();"
>> So did you mean StyleBuilder.cpp? i.e. adding a new class, e.g. ApplyPropertyUserModify and implementing an original applyInheritValue?
> 
> Yep, that seems like the more logical approach.

I think, applyProperty will be invoked when an element has some matched properties, i.e. suppose that A is a distributed node and there exists "<style>A { -webkit-user-modify: inherit }</style>" or something. I think, this is another issue to be discussed.
The issue I would like to fix in this bug is, for example,

    <host> --------- (SR)
         |           |
         +---- <A>    +---<div>
                           |
                           +---<content> (or <shadow>)

(<host content-editable>
    <#shadow-root><div><content /></div></#shadow-root>
    <A></A>
 </host>) 

A has no matched styles related to -webkit-user-modify.
The host is "content-editable". <div> is not "content-editable".
A's style is inherited from <div>'s style, because A's parentNodeForStyle is <div>.

A should be content-editable or not?

So this patch makes A content-editable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.