[Webkit-unassigned] [Bug 94397] Web Inspector: expose object internal properties such as PrimitiveValue or BoundThis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94397


Peter Rybin <prybin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #165655|commit-queue-               |commit-queue?
               Flag|                            |




--- Comment #17 from Peter Rybin <prybin at chromium.org>  2012-09-26 07:00:58 PST ---
(From update of attachment 165655)
View in context: https://bugs.webkit.org/attachment.cgi?id=165655&action=review

>> LayoutTests/inspector-protocol/runtime-getProperties.html:50
>> +                processStep(next);
> 
> Consider moving this into the try block.

processStep is a one big try itself.

>> LayoutTests/inspector-protocol/runtime-getProperties.html:90
>> +        if (id === undefined)
> 
> if (!id) would work

Technically yes, but I'd like not think about whether id can legitimately 0 (no) or empty string (no).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.