[Webkit-unassigned] [Bug 50000] [Qt] Remove redundant JAVASCRIPTCORE_JIT variable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 26 00:03:58 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=50000





--- Comment #5 from Simon Hausmann <hausmann at webkit.org>  2012-09-26 00:04:25 PST ---
(From update of attachment 74715)
View in context: https://bugs.webkit.org/attachment.cgi?id=74715&action=review

> WebKit.pri:90
> -    contains(JAVASCRIPTCORE_JIT,yes): error("'JAVASCRIPTCORE_JIT=yes' not supported with valgrind")
> +    contains(DEFINES, ENABLE_JIT=1): error("'ENABLE_JIT=1' not supported with valgrind, setting ENABLE_JIT=0")

This check is not correct, with --smc-check=all-non-file valgrind appears to work just fine.

> common.pri:-4
> -contains(JAVASCRIPTCORE_JIT,yes): DEFINES+=ENABLE_JIT=1
> -contains(JAVASCRIPTCORE_JIT,no): DEFINES+=ENABLE_JIT=0

Yeah, let's get rid of this variable. I believe we've already removed the corresponding "configure option" from qt's configure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list