[Webkit-unassigned] [Bug 89742] [Win] key event's location does not work on Windows platform.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89742


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162416|review?                     |review-
               Flag|                            |




--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org>  2012-09-25 15:57:03 PST ---
(From update of attachment 162416)
View in context: https://bugs.webkit.org/attachment.cgi?id=162416&action=review

r- due to style issues.

> Source/WebCore/ChangeLog:9
> +        Additional information of the change such as approach, rationale. Pleas        As WM_KEYDOWN, WM_KEYUP, WM_SYSKEYDOWN, and WM_SYSKEYUP doesn't
> +        directly provide a virtual keycode which distinguish between left-hand

These two lines of changelogs are messed up.

> Source/WebCore/platform/win/KeyEventWin.cpp:189
> +static int windowsKeycodeWithLocation(WPARAM wparam, LPARAM lparam)

It's better to give these argument variable more descriptive names like keycode.

> Source/WebCore/platform/win/KeyEventWin.cpp:196
> +    // 24bit: Indicates whether the key is an extended key, such as
> +    // the right-hand ALT and CTRL keys.

This is quite obvious from the code.

> Source/WebCore/platform/win/KeyEventWin.cpp:197
> +    // However, if we don't need to support WindowsXP or older Windows,

Nit: Windows XP.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.