[Webkit-unassigned] [Bug 97569] Assertion failure in non-JIT'ed LLInt on ARM Thumb

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97569





--- Comment #2 from Mark Lam <mark.lam at apple.com>  2012-09-25 14:32:22 PST ---
(From update of attachment 165638)
View in context: https://bugs.webkit.org/attachment.cgi?id=165638&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:39
> +#if CPU(ARM_THUMB2) && !ENABLE(COMPUTED_GOTO_OPCODES)

Your comment in the ChangeLog suggests that this issue only manifests when LLINT_C_LOOP is enabled.  I would be more comfortable if you change the above to the following instead:

#if CPU(ARM_THUMB2) && !(ENABLE(LLINT_C_LOOP) && ENABLE(COMPUTED_GOTO_OPCODES))

This way, the assertion is not disabled for the more common use case where the llint C++ backend is not in use.

> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:46
> +// when we enable features that use labels-as-values.

I suggest "... use labels-as-values e.g. ENABLE(LLINT_C_LOOP) with ENABLE(COMPUTED_GOTO_OPCODES).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.