[Webkit-unassigned] [Bug 97583] [GTK][EFL] Disk cache is never dumped to disk in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97583





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-09-25 11:39:48 PST ---
(In reply to comment #2)
> (From update of attachment 165647 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165647&action=review
> 
> > Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:107
> > +    soup_cache_flush(soupCache);
> > +    soup_cache_dump(soupCache);
> > +    g_object_unref(soupCache);
> > +
> 
> I'm surprised that g_object_unref doesn't flush and dump the cache as a side-effect. Maybe Dan or Sergio can comment on that? If that's the case, we can just call g_object_unref here.

No, finalize() only frees the internal hash table, but the cache needs to be flushed and dumped manually. Serio told me it's expected to be done when the process finishes and the cache is not going to be used more, because there isn't a way to block the cache while flush/dump.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.