[Webkit-unassigned] [Bug 97583] [GTK][EFL] Disk cache is never dumped to disk in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97583





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-09-25 11:35:04 PST ---
(From update of attachment 165647)
View in context: https://bugs.webkit.org/attachment.cgi?id=165647&action=review

> Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:107
> +    soup_cache_flush(soupCache);
> +    soup_cache_dump(soupCache);
> +    g_object_unref(soupCache);
> +

I'm surprised that g_object_unref doesn't flush and dump the cache as a side-effect. Maybe Dan or Sergio can comment on that? If that's the case, we can just call g_object_unref here.

> Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:90
> +    soup_cache_flush(soupCache.get());
> +    soup_cache_dump(soupCache.get());
> +

Assuming that the soup cache destructor takes care of this, this could just become:

soupCache = nullptr;

And with a comment explaining why it's important to do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.