[Webkit-unassigned] [Bug 90017] [Meta] [Shadow] contenteditable attribute for distributed nodes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90017


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161609|review?                     |review-
               Flag|                            |




--- Comment #7 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-09-25 09:02:50 PST ---
(From update of attachment 161609)
View in context: https://bugs.webkit.org/attachment.cgi?id=161609&action=review

>>> Source/WebCore/css/StyleResolver.cpp:1783
>>> +    if (m_distributedToInsertionPoint) {
>> 
>> This seems like an odd place for this code. Should this not be in StyleResolver::applyProperty?
> 
> In StyleResolver::applyProperty, I found that "case CSSPropertyWebkitUserModify:" is "ASSERT_NOT_REACHED();"
> So did you mean StyleBuilder.cpp? i.e. adding a new class, e.g. ApplyPropertyUserModify and implementing an original applyInheritValue?

Yep, that seems like the more logical approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.