[Webkit-unassigned] [Bug 17427] Line breaking opportunities at the end of a text node are missed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 21:02:06 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=17427


Alex Henrie <alexhenrie24 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164653|0                           |1
        is obsolete|                            |
 Attachment #165510|                            |review?, commit-queue?
               Flag|                            |




--- Comment #18 from Alex Henrie <alexhenrie24 at gmail.com>  2012-09-24 21:02:32 PST ---
Created an attachment (id=165510)
 --> (https://bugs.webkit.org/attachment.cgi?id=165510&action=review)
Proposed patch v3

Try 3. I used a StringBuilder this time, and made the code only concatenate the context together once for an entire set of runs. This works quite nicely. I tried a few different ways and finally settled on using a hash table to determine where each text node lies in the context string. I'll email Michael Saboff to ask what would have to be done to change this code to use UText instead of StringBuilder, but I think this patch would be fine as-is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list