[Webkit-unassigned] [Bug 95268] garden-o-matic doesn't handle multiple TestExpectations files properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95268





--- Comment #8 from Dirk Pranke <dpranke at chromium.org>  2012-09-24 12:48:47 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > Just a random thought: if we _disable_ multi-platform expectations syntax in lieu of cascading expectations, we might be able to make the algorithm of collapsing a set of TestConfigurations into specifiers/modifiers easier, because now we have a simple tree structure to rely upon. Of course, this means more pain for gardeners (who now need to modify multiple files), but maybe that's not a big issue, if we have the right tooling?
> 

I would expect the algorithms to be somewhat easier, but it's hard to say. For one thing, you could no longer treat things consistently: how you treated a debug-only failure would be different from a lion-only failure, and how you treated a lion-only failure would be different from a mac-wide failure. I fear we'd have more special-case logic in the code, but I haven't thought about it a lot yet.

Also, we have to remember that multiple files is needed for *both* platform-specific expectations *and* overrides. Right now the concern I have is figuring out how to deal with the override aspect of the problem.

I do think it would be good to make all of the ports work consistently, and I wonder how much the need for platform-specific expectations will be reduced once we start checking in failures.

That said, I no longer think anything will be "considerably" simpler in this part of the code :).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.