[Webkit-unassigned] [Bug 84624] Table: padding on inline-element not calculated in cell-width

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 11:52:03 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84624





--- Comment #3 from Julien Chaffraix <jchaffraix at webkit.org>  2012-09-24 11:52:31 PST ---
(From update of attachment 154859)
View in context: https://bugs.webkit.org/attachment.cgi?id=154859&action=review

> Julien, what do you think?

This patch will impact any RenderBlocks and not just RenderTableCells. The ChangeLog seems to suggest that this is table cell specific so it should be clarified.

> Source/WebCore/rendering/RenderBlock.cpp:5872
> +                isPrevChildInlineFlow = false;

Interestingly, we don't set isPrevChildInlineFlow in the else branch below which looks suspicious. Ideally you want to update |isPrevChildInlineFlow| for every iteration so it should probably be pushed to the end of the while loop (outside of any branch to garantee that it is updated)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list