[Webkit-unassigned] [Bug 93473] Web Inspector: The front-end should provide the position in original source file when set a breakpoint

Mon Sep 24 08:58:09 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=93473

Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161964|review?                     |review-
               Flag|                            |

--- Comment #14 from Yury Semikhatsky <yurys at chromium.org>  2012-09-24 08:58:36 PST ---
(From update of attachment 161964)
View in context: https://bugs.webkit.org/attachment.cgi?id=161964&action=review

Can you provide a test for this?

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:144
> +        m_lastExecutedLine = lineNumber;

has* methods should not modify the object, this is why in particular it was marked const.

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:162
> +        // Since frontend truncates the indent, so the first statement in a line must matches the breakpoint (line, 0).

typo: Since frontend truncates the indent, the first statement in a line must match the breakpoint

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.