[Webkit-unassigned] [Bug 91844] [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164889|review?                     |review+
               Flag|                            |




--- Comment #53 from Simon Hausmann <hausmann at webkit.org>  2012-09-24 05:30:28 PST ---
(From update of attachment 164889)
View in context: https://bugs.webkit.org/attachment.cgi?id=164889&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:106
> +#elif PLATFORM(EFL) && defined(HAVE_ECORE_X)
> +    return ecore_x_screen_index_get(ecore_x_default_screen_get());

I still think that this kind of stuff can easily be simplified to use Xlib functions (see PLATFORM(QT) code path), given a platform-specific way of getting the X display. But that can be done in a separate patch if you'd like.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.