[Webkit-unassigned] [Bug 97272] Web Inspector: Catch exceptions in JavaScriptSource workingCopyCommit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97272


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #165013|review?                     |review-
               Flag|                            |




--- Comment #2 from Vsevolod Vlasov <vsevik at chromium.org>  2012-09-24 05:12:28 PST ---
(From update of attachment 165013)
View in context: https://bugs.webkit.org/attachment.cgi?id=165013&action=review

> Source/WebCore/inspector/front-end/JavaScriptSource.js:104
> +            var rawLocation = this.uiLocationToRawLocation(0, 0);

We try to avoid exceptions in inspector code.
Why not use 
if (!rawLocation)
    return;
instead?

> LayoutTests/inspector/debugger/live-edit.html:14
> +    WebInspector.showPanel("scripts");

var panel = WebInspector.showPanel("scripts");

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.