[Webkit-unassigned] [Bug 96023] Expose ability to create WebUserMediaRequest from chromium side

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 02:22:03 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96023


Tommy Widenflycht <tommyw at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tommyw at google.com




--- Comment #17 from Tommy Widenflycht <tommyw at google.com>  2012-09-24 02:22:30 PST ---
Hmm, I don't particularly like this patch either since it is too much of a hack. You are trying to squeese in functionality using classes not designed for that purpose which can lead to trouble later on. In WebKit the philosophy is that we try to do a proper design even if it takes much more time, of which I btw have personal experience, since it leads to better code.

You also break the "contract" that all mediastream Web* classes corresponds to a WebCore/platform object. This is a relatively minor objection though.

Have you tried creating your own request class instead of reusing WebUserMediaRequest, and doing a bit of refactoring on the chromium side?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list