[Webkit-unassigned] [Bug 95268] garden-o-matic doesn't handle multiple TestExpectations files properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95268





--- Comment #4 from Ojan Vafai <ojan at chromium.org>  2012-09-21 16:53:26 PST ---
It's not clear to me what the right behavior is. Here's one brainstorm idea.
Consider the case of rebaselining a test that has an entry in platform/mac. 

1. Copy that entry into all the TestExpectations files that depend on platform/mac.
2. Remove the entry from each TestExpectations file for each bot that you rebaseline. You only remove platform/mac one if you are rebaselining the latest mac port (i.e. Mountain Lion), remove the platform/mac-lion entry iff you're rebaselining the Lion bot, etc. There should be at least one bot per TestExpectations file, right?

In the common case where you are rebaselining all the mac ports, the entry will effectively get removed from all TestExpectations files.

The potential downside to this is that if you're not rebaselining all the ports, you'll end up with stray leftover lines, but this is pretty much how garden-o-matic works in general anyways with modifying baselines, so I'm inclined to say that's ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.