[Webkit-unassigned] [Bug 97321] Web Inspector: Highlight multiple nodes in page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97321





--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2012-09-21 06:20:49 PST ---
(From update of attachment 165124)
View in context: https://bugs.webkit.org/attachment.cgi?id=165124&action=review

> Source/WebCore/inspector/Inspector.json:1814
> +                    { "name": "highlightConfig", "$ref": "HighlightConfig", "description": "A descriptor for the highlight apperance." }

I wonder if we want to have a config per node. I can imagine a list of nodes where there is a parent node that is only rendered as border and a list of child nodes that are rendered as boxes.

> Source/WebCore/inspector/InspectorController.cpp:82
> +    , m_overlays(InspectorOverlayCollection::create(page, inspectorClient))

You should only have one overlay, just make InspectorOverlay::highlightNode receive an array of nodes (and configs).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.