[Webkit-unassigned] [Bug 95114] Web Inspector: Refactor SourceFrame to delegate highlightLine() to _textEditor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95114


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162337|review?                     |review-
               Flag|                            |




--- Comment #5 from Pavel Feldman <pfeldman at chromium.org>  2012-09-21 03:05:11 PST ---
(From update of attachment 162337)
View in context: https://bugs.webkit.org/attachment.cgi?id=162337&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:173
> +        return this._textEditor.canHighlightLine();

SourceFrame should be always able to highlight the line.

> Source/WebCore/inspector/front-end/SourceFrame.js:-193
> -                delete this._lineToHighlight

What about the case when we get request for the line highlight before the content has loaded into the text editor? Like stopping on a breakpoint that leads to the SourceFrame being opened.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.