[Webkit-unassigned] [Bug 96465] [EFL][WK2] TestRunner needs touch events support.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96465





--- Comment #3 from Ryuan Choi <ryuan.choi at samsung.com>  2012-09-21 01:12:47 PST ---
(From update of attachment 165074)
View in context: https://bugs.webkit.org/attachment.cgi?id=165074&action=review

Thank you.

> Tools/ChangeLog:3
> +        [EFL][WK2] TestRunner needs touch events support.

We can update testExpectations in LayoutTests. Am I right?

> Tools/WebKitTestRunner/EventSenderProxy.h:37
> +#if ENABLE(TOUCH_EVENTS)

I think that it looks not needed

> Tools/WebKitTestRunner/EventSenderProxy.h:137
> +    Vector<Ewk_Touch_Point> m_touchPoints;

Isn't it usefull using Eina_List instead of Vector?

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:433
> +    for (unsigned i = 0; i < m_touchPoints.size(); i++) {

s/unsigned/size_t and ++i is preferred.

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:522
> +    Ewk_Touch_Point* touchPoint = &m_touchPoints[index];
> +    touchPoint->state = EVAS_TOUCH_POINT_UP;

I think that touchPoint is not needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.