[Webkit-unassigned] [Bug 88606] [Shadow DOM] Needs @host rule for ShadowDOM styling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88606





--- Comment #23 from Takashi Sakamoto <tasak at google.com>  2012-09-20 21:59:47 PST ---
(From update of attachment 164506)
View in context: https://bugs.webkit.org/attachment.cgi?id=164506&action=review

Thank you for reviewing. I filed a new bug 97184, which blocks this bug 88606. After finishing bug 97184, I will request review again.

Best regards,
Takashi Sakamoto

>> Source/WebCore/css/StyleResolver.cpp:1112
>> +        transferMatchedRules(result);
> 
> This is wrong. We should somehow change the specificity of the @host at-rules, so that it all works as sort-and-match. Hmmm.. This might be a spec bug.

I see. I modified "RuleSet::addStyleRule" and "RuleSet::addRule" to modify RuleData's specificity when the given style rule comes from @host @-rules.

>> Source/WebCore/css/StyleResolver.h:556
>> +    bool matchesHostRules();
> 
> please group functions with functions and data with data.

Done.

>> Source/WebCore/dom/ShadowRoot.h:94
>> +    bool hasShadowInsertionPoint() const { return m_numberOfShadowElementChildren > 0; }
> 
> This seems like a separate, smaller patch.

I filed a new bug for this, i.e. https://bugs.webkit.org/show_bug.cgi?id=97184.
My patch still has these changes... to pass cq-bot check. I will remove these changes after a patch for bug 97184 is landed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.