[Webkit-unassigned] [Bug 96932] [GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96932





--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2012-09-20 14:02:25 PST ---
(From update of attachment 164839)
View in context: https://bugs.webkit.org/attachment.cgi?id=164839&action=review

> Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:95
> +        for (RenderObject* r = renderer()->firstChild(); r; r = r->nextSibling()) {
> +            if (r->isAnonymousBlock())
> +                return IncludeObject;

I notice here that the check for child->isLink() is gone now. Was it unimportant before or was it replaced by another check? I'm also a bit confused by the change in logic. I'm probably reading it incorrectly.

My understanding:
Before: If the child is a link or the first child isn't an anonymous block, include the object.
Now: If any child is an anonymous block, include the object.

Not sure I understand that fully.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.