[Webkit-unassigned] [Bug 91844] [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844





--- Comment #48 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-09-20 05:57:55 PST ---
(In reply to comment #47)
> (In reply to comment #46)
> > (In reply to comment #45)
> > > (In reply to comment #35)
> > > > (From update of attachment 164363 [details] [details] [details] [details])
> > > > I'm not sure about some of the files, the implementation is the same because it's currently unimplemented, not because the implementation is expected to be common to all ports in a unix platform. PluginProcess/unix/PluginProcessMainUnix.cpp should probably be X11 instead of Unix, but it requires a lot of #ifdefs so I'm not sure whether it would be better to keep separate files without #ifdefs. Note also that Qt port could also share code common to unix platform, like in Platform/CoreIPC/unix/ConnectionUnix.cpp, but it seems to me that most of the files shared here are not for platform specific code, but for port specific code.
> > > 
> > > PluginProcessMainUnix seems to be more "unix" than "x11" because X11 support adds only error handling.
> > > Sometimes it's hard to point the best solution: port, backend, operating system.
> > > What's your suggestion?
> > 
> > My suggestion is to keep separate files instead of a "common" file full of #ifdefs
> 
> A lot of proposed changes have common source. I think PluginControllerProxyUnix.cpp, and PluginProcessUnix.cpp can be EFL and Gtk as before because of platform initialize, and destroy, but others may stay as is. Do you agree with it?

They have a common source because they are unimplemented not because they are supposed to have a common implementation for unix platform. The code is also the same as the Qt files, if we are going to share the unimplemented files, we should include the Qt files as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.