[Webkit-unassigned] [Bug 96502] [GTK] ControlsPanel string is not localized in LocalizedStringsGtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 20 04:02:05 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96502





--- Comment #4 from Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com>  2012-09-20 04:02:34 PST ---
(In reply to comment #3)
> It strucks me that we're the only port hitting this issue. Especially given this FIXME in LocalizedStrings.cpp
> 
>     // FIXME: the ControlsPanel container should never be visible in the accessibility hierarchy.
> 
> Can you clarify this please? :)

It took a bit of spelunking (this FIXME is well traveled, having been moved several times as part of refactors and other changes). But I discovered its birth:

http://trac.webkit.org/changeset/49206/trunk/WebKit/mac/WebCoreSupport/WebViewFactory.mm

I don't know what other platforms expect, but having media controls floating outside of a logical parent container strikes me as being quite odd.

Would you like me to amend the FIXME to indicate that at least the Gtk port expects this object?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list