[Webkit-unassigned] [Bug 91844] [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844





--- Comment #39 from Mariusz Grzegorczyk <mariusz.g at samsung.com>  2012-09-20 02:26:53 PST ---
(From update of attachment 164363)
View in context: https://bugs.webkit.org/attachment.cgi?id=164363&action=review

>> Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:61
>> +#endif
> 
> This doesn't seem very scalable... what if Qt decided to use this code? Maybe abstract this in Platform.h?

Changed to webkit's log

>> Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:77
>> +    bool scanPlugin = !strcmp(argv[1], "-scanPlugin");
> 
> why not two -s? --scan-plugins

Qt and Gtk are using "-scanPlugin" so I think it can be left as is to avoid changes on their ports.

>> Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:87
>> +#endif
> 
> I guess you rather what a platformInitialize() method for so

platformInitialize is done later in "WebKit::PluginProcess::shared().initialize(socket, RunLoop::main());" line. Here gtk needs arguments from command line, and efl needs ecore x init before platformInitialize.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.