[Webkit-unassigned] [Bug 88606] [Shadow DOM] Needs @host rule for ShadowDOM styling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88606


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164506|review?                     |review-
               Flag|                            |




--- Comment #21 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-09-19 10:21:35 PST ---
(From update of attachment 164506)
View in context: https://bugs.webkit.org/attachment.cgi?id=164506&action=review

Thank you for working on this!

> Source/WebCore/css/StyleResolver.cpp:1112
> +        transferMatchedRules(result);

This is wrong. We should somehow change the specificity of the @host at-rules, so that it all works as sort-and-match. Hmmm.. This might be a spec bug.

> Source/WebCore/css/StyleResolver.h:556
> +    RuleSet* atHostRuleSetForScope(const ShadowRoot*);
> +    bool matchesHostRules();

please group functions with functions and data with data.

> Source/WebCore/dom/ShadowRoot.h:94
> +    void registerShadowElement() { ++m_numberOfShadowElementChildren; }
> +    void unregisterShadowElement() { --m_numberOfShadowElementChildren; }
> +    bool hasShadowInsertionPoint() const { return m_numberOfShadowElementChildren > 0; }

This seems like a separate, smaller patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.