[Webkit-unassigned] [Bug 17427] Line breaking opportunities at the end of a text node are missed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17427


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164653|review?                     |review-
               Flag|                            |




--- Comment #16 from Darin Adler <darin at apple.com>  2012-09-19 10:00:40 PST ---
(From update of attachment 164653)
View in context: https://bugs.webkit.org/attachment.cgi?id=164653&action=review

Please fix the style complaints from the style checking. They are all correctly expressing WebKit coding style.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2446
> +                    // Thai and other Southeast Asian languages use dictionary-based line breaking algorithms that require a lot of context

Please add a period to this sentence-style comment.

The comment is a bit mysterious. This says “a lot of context”, but does not explain how much is enough.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2447
> +                    String textWithContext;

Just using a StringBuilder instead of a String will be significantly more efficient. But perhaps we can do even better.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2468
> +                        current.m_nextBreakablePosition = 0; // Yes, a line break may occur immediately before

I find this comment confusing. Maybe you could rewrite it to be a bit more explicit?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.