[Webkit-unassigned] [Bug 94925] [EFL][UT]Refactoring an implementation of testing framework for wk1.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94925





--- Comment #39 from Christophe Dumez <christophe.dumez at intel.com>  2012-09-19 09:02:58 PST ---
(In reply to comment #38)
> (From update of attachment 164727 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164727&action=review
> 
> > Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:42
> > +    ASSERT_GT(ecore_evas_init(), 0);
> 
> It is already called in ewk_init(), it is not needed here.
> 
> > Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:43
> > +    ASSERT_GT(ewk_init(), 0);
> 
> We cannot let the ewk_main ref count go to 0 during the program execution or we will do WebCore initializations more than once, which will cause assertions. With your patch, the ref count goes down to 0 after each unit test and ewk_init() will therefore initialize WebCore again next time it is called. You probably need to call ewk_init() / ewk_shutdown() in the EWKTestBase constructor / destructor as well, so that ref count stays 1 between tests.

I actually don't believe we need to call ewk_init() / ewk_shutdown() before and after each test. It is probably just enough to call them once in the ctr/dtor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.