[Webkit-unassigned] [Bug 96300] [CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 19 08:08:12 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96300





--- Comment #4 from Raul Hudea <rhudea at adobe.com>  2012-09-19 08:08:42 PST ---
(In reply to comment #3)
> (From update of attachment 164713 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review
> 
> > Source/WebCore/css/StyleRule.cpp:87
> > +        ASSERT_NOT_REACHED();
> 
> Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable?

in that StyleRule.cpp, all 4 types (Unknown, Charset, Keyframe and Regions(when ) are unreachable in all other functions: createCSSOMWrapper(), destroy() and copy(). So, they should also trigger an assert in reportMemoryUsage. They are marked as "Not used" in StyleRule.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list