[Webkit-unassigned] [Bug 94925] [EFL][UT]Refactoring an implementation of testing framework for wk1.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94925





--- Comment #28 from Krzysztof Czech <k.czech at samsung.com>  2012-09-19 02:24:18 PST ---
(In reply to comment #26)
> (From update of attachment 164556 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164556&action=review
> 
> > Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp:66
> > +    evas_object_focus_set(m_webView.get(), true);
> 
> In public API case, I think it is better to use EINA_FALSE | _TRUE to test for public API. Because, this API will be used by EFL application. So, awk2 test case also uses EINA_TRUE | FALSE.
Done.
> 
> > Source/WebKit/efl/tests/test_ewk_view.cpp:37
> > +    ewk_view_editable_set(webView(), false);
> 
> ditto.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.