[Webkit-unassigned] [Bug 17427] Line breaking opportunities at the end of a text node are missed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17427


Alex Henrie <alexhenrie24 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164653|                            |review?, commit-queue?
               Flag|                            |




--- Comment #13 from Alex Henrie <alexhenrie24 at gmail.com>  2012-09-18 20:45:28 PST ---
Created an attachment (id=164653)
 --> (https://bugs.webkit.org/attachment.cgi?id=164653&action=review)
Proposed patch v2

Okay, here is version 2 of the patch (the segfault seems to have been fixed in the latest SVN revision). I added a test for Thai line breaking this time around. Also, I got around the failure on fast/text/line-break-before-text-node.html by not running the new code if -webkit-text-combine is present.

I know that the string manipulation in this patch is highly inefficient; help would really be appreciated. [1] and [2] talk about creating UText objects from discontinuous strings but it is not clear whether this feature is anything more than theoretical. Any other information about how you want the solution to look would also be helpful.

[1] http://userguide.icu-project.org/strings/utext
[2] http://icu-project.org/apiref/icu4c/utext_8h.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.