[Webkit-unassigned] [Bug 95614] Add support for blendmode to platform code for mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95614





--- Comment #11 from Rik Cabanier <cabanier at adobe.com>  2012-09-18 15:21:48 PST ---
(In reply to comment #10)
> (From update of attachment 163315 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163315&action=review
> 
> > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2794
> > +void GraphicsLayerCA::updateBlending()
> > +{
> > +    primaryLayer()->setBlendMode(m_blendMode);
> > +    
> > +    if (LayerMap* layerCloneMap = primaryLayerClones()) {
> > +        LayerMap::const_iterator end = layerCloneMap->end();
> > +        for (LayerMap::const_iterator it = layerCloneMap->begin(); it != end; ++it) {
> > +            if (m_replicaLayer && isReplicatedRootClone(it->first))
> > +                continue;
> > +            it->second->setBlendMode(m_blendMode);
> > +        } 
> > +    }
> > +}
> 
> Does this play nicely with -webkit-transform: preserve-3d? Before, we've had spew from Core Animation when setting filters on a CATransformLayer.

It plays along fairly well. If you set the blend mode on an object that has a 3d transform, it will blend in 3d. I did not see any warnings.

If you set a blend (or opacity or a filter) on an element, preserve-3d is supposed to be ignored but that doesn't happen today. That would be a new bug if you want me to look into that...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.