[Webkit-unassigned] [Bug 96497] [GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96497





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-09-18 10:47:24 PST ---
(In reply to comment #11)
> (From update of attachment 164548 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164548&action=review
> 
> Looks good. Couple small suggestions before landing...
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSecurityManager.cpp:59
> > +static void webkit_security_manager_class_init(WebKitSecurityManagerClass* findClass)
> 
> Small nit here: findClass could just be klass or securityManagerClass. I guess this is just a copy-paste thing?

hehe, yes, I copied this from the CookieManager that was copied from the FindCrontroller. The CookieManager still has findClass :-P

> > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:318
> > +    void check(const char* scheme, unsigned policy)
> 
> Maybe a name like verifyThatSchemeMatchesPolicy?

Sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.