[Webkit-unassigned] [Bug 96497] [GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 18 10:39:50 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96497


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164548|review?                     |review+
               Flag|                            |




--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2012-09-18 10:40:19 PST ---
(From update of attachment 164548)
View in context: https://bugs.webkit.org/attachment.cgi?id=164548&action=review

Looks good. Couple small suggestions before landing...

> Source/WebKit2/UIProcess/API/gtk/WebKitSecurityManager.cpp:59
> +static void webkit_security_manager_class_init(WebKitSecurityManagerClass* findClass)

Small nit here: findClass could just be klass or securityManagerClass. I guess this is just a copy-paste thing?

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:318
> +    void check(const char* scheme, unsigned policy)

Maybe a name like verifyThatSchemeMatchesPolicy?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list