[Webkit-unassigned] [Bug 94925] [EFL][UT]Refactoring an implementation of testing framework for wk1.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94925





--- Comment #23 from Krzysztof Czech <k.czech at samsung.com>  2012-09-18 06:50:25 PST ---
(In reply to comment #22)
> (From update of attachment 163888 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163888&action=review
> 
> > Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:49
> > +    m_ewkTestView = new EWKTestView();
> 
> You could use an OwnPtr here so you do not need to delete this pointer manually later.
I wanna be sure m_ewkTestView is destroyed before ecore_evas_shutdown() and ewk_shutdown(), this is the reason I don't use OwnPtr in this particular case.
> 
> > Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h:46
> >      OwnPtr<Evas_Object> m_webView;
> 
> Evas_Objects should be wrapped inside RefPtrs now.
Thanks, I will correct.
> 
> > Source/WebKit/efl/tests/test_runner.cpp:18
> >  */
> > +#include "config.h"
> 
> Very minor nit: I would add an empty line before this #include.
Thanks, I will correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.