[Webkit-unassigned] [Bug 96508] [chromium] Fix parameter names selectionBounds and selectRange, remove moveSelectionStart/End/Caret

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 18 05:50:03 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96508





--- Comment #13 from Iain Merrick <husky at chromium.org>  2012-09-18 05:50:32 PST ---
(From update of attachment 164414)
View in context: https://bugs.webkit.org/attachment.cgi?id=164414&action=review

>> Source/WebKit/chromium/src/WebFrameImpl.cpp:1477
>> +        TextGranularity granularity = frameSelection->isNone() ? CharacterGranularity : frameSelection->granularity();
> 
> This doesn't look right. Why do we want to select a word just because a word was selected elsewhere before?

Hmm, that felt like the right way to handle an existing selection, but you're right, there isn't really a use case for this and it isn't being tested.

Will just use character granularity.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list