[Webkit-unassigned] [Bug 94779] To reduce cost of converting type during modulo for integers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94779





--- Comment #17 from Filip Pizlo <fpizlo at apple.com>  2012-09-18 00:07:46 PST ---
(In reply to comment #16)
> (In reply to comment #14)
> Really thank you for your review and comment, Filip
> 
> > Created an attachment (id=164488)
 --> (https://bugs.webkit.org/attachment.cgi?id=164488&action=review) [details] [details]
> > test case for C modulo
> > 
> > Run this on your compute:
> > 
> > cc -o test test.c
> > ./test -2147483648 -1
> > 
> > You should get a SIGFPE on UNIX-like systems, or whatever the equivalent exception is on non-UNIX systems.
> > 
> > In general it is not safe to use C modulo for -2147483648/-1.
> 
> I did concern what you tested but my device, on linux, didn't throw any signal so I didn't add speculationCheck for (-2147483648).
> Plus score was not good if the patch had have that check routine.

I prefer a browser that doesn't crash over a browser that computes prime numbers quickly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.