[Webkit-unassigned] [Bug 96610] [EFL][WK2] Regression (r128163)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96610


Christophe Dumez <christophe.dumez at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christophe.dumez at intel.com




--- Comment #14 from Christophe Dumez <christophe.dumez at intel.com>  2012-09-17 22:11:18 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > (From update of attachment 164479 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=164479&action=review
> > 
> > > Source/WebKit2/ChangeLog:3
> > > +        [EFL][WK2] Regression (r128163)
> > 
> > Please add a title after Regression (r128163):
> > 
> > > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:-501
> > > -    EINA_SAFETY_ON_NULL_RETURN_VAL(priv->evasGl, false);
> > 
> > EINA_SAFETY_ON_TRUE_RETURN_VAL(priv->evasGl, false); ?
> 
> As previous comments mentioned, EINA_SAFETY_ON_TRUE_RETURN_VAL(priv->evasGl, false) makes a below build break with --tiled-backing-store option.
> 
> /home/gyuyoung/webkit/WebKit/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:501:5: error: invalid conversion from ‘Evas_GL* {aka _Evas_GL*}’ to ‘long int’ [-fpermissive]

Maybe EINA_SAFETY_ON_TRUE_RETURN_VAL(!!priv->evasGl, false); would have worked then?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.