[Webkit-unassigned] [Bug 91844] [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91844





--- Comment #36 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-09-17 06:25:37 PST ---
(From update of attachment 164363)
View in context: https://bugs.webkit.org/attachment.cgi?id=164363&action=review

> Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:61
> +#if PLATFORM(GTK)
> +    g_warning(
> +#elif PLATFORM(EFL)
> +    EINA_LOG_CRIT(
> +#endif

This doesn't seem very scalable... what if Qt decided to use this code? Maybe abstract this in Platform.h?

> Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:77
> +    bool scanPlugin = !strcmp(argv[1], "-scanPlugin");

why not two -s? --scan-plugins

> Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:87
> +#if PLATFORM(GTK)
> +    gtk_init(&argc, &argv);
> +#elif PLATFORM(EFL)
> +    if (!eina_init())
> +        return 1;
> +#ifdef HAVE_ECORE_X
> +    if (!ecore_x_init(0))
> +#endif

I guess you rather what a platformInitialize() method for so

> Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:66
> +    int status;
> +    char* stdOut;
> +
> +    if (!g_spawn_sync(0, argv, 0, G_SPAWN_STDERR_TO_DEV_NULL, 0, 0, &stdOut, 0, &status, 0))
> +        return false;
> +

This looks so much more like a PluginProcessProxyGlib than a UNIX one

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.