[Webkit-unassigned] [Bug 96481] [Qt][WK2] Add API to find text from page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96481





--- Comment #11 from Simon Hausmann <hausmann at webkit.org>  2012-09-14 22:53:29 PST ---
(From update of attachment 164054)
View in context: https://bugs.webkit.org/attachment.cgi?id=164054&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:295
> +    enum FindFlags {
> +        FindCaseSensitively = 1 << 0,
> +        FindBackward = 1 << 1,
> +        FindWrapsAroundDocument = 1 << 2,
> +        FindHighlightAllOccurrences = 1 << 3
> +    };

This should probably become a real QFlag, i.e. this type is called FindFlag and then you use Q_DECLARE_FLAGS and Q_DECLARE_OPERATORS_FOR_FLAGS to turn FindFlag into FindFlags. Then you can combine them with logical and and or operators without the need for casting, registered in the class with Q_FLAGS it makes them properly accessible through introspection and you'll get a default constructor that avoids the options = static_cast<FindFlags>(0) :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.