[Webkit-unassigned] [Bug 96497] [GTK] Add API to get/set the security policy of a given URI scheme to WebKit2 GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96497





--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2012-09-14 10:52:15 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > This is not designed to remove uri schemes
> > 
> > If that's not a usecase you want to support it makes sense to match the WebCore API, I think. Only expose the register* methods. That way it's unambiguous. I can see this being very confusing if you try to change the security policy of a scheme (calling webkit_web_context_set_security_policy_for_uri_scheme more than once for the same scheme).
> 
> You are right, it can be confusing, maybe we could add a WebKitSecurityPolicy object with methods to register uri schemes:
> 
> webkit_secutiry_policy_register_uri_scheme_as_local()
> webkit_secutiry_policy_register_uri_scheme_as_secure()
> ....
> 
> And also methods to query:
> 
> webkit_secutiry_policy_is_uri_scheme_local()
> webkit_secutiry_policy_is_uri_scheme_secure()
> ....
> 
> And method to get the security policy object (or boxed type) from the context
> 
> WebKitSecutiryPolicy* webkit_web_context_get_secutory_policy().
> 
> I used the flags to reduce the api, but I agree it can be confusing, we should do the same in wk1.

You're suggestion makes sense to me. Sorry that I didn't notice this when you did the version for WebKti1!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.